-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up husky & lint-staged AB#32125 #1854
Conversation
7140beb
to
ea7986c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part looks good to me. I also found that we had to iterate a few times on the 121-platform until we ironed out all the kinks, so it might be ok to just get people using it and then adjust accordingly.
log "Running custom pre-commit hook defined in ./husky/pre-commit" | ||
|
||
# Prevent committing to "main"-branch: | ||
if [ "$(git rev-parse --abbrev-ref HEAD)" = "main" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jannisvisser @arsforza This will not work because IBF does not have a main
branch. It does have a master
branch which we could use. Or create a main
branch and use that instead of master
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point I'll correct it
Describe your changes
Copy husky & lint-staged setup from 121, to make sure we properly run prettier and lint automatic fixes on commit, and only on staged files.
Checklist before requesting a review